Files
Memoh/internal/conversation/flow/resolver_title.go
T
Acbox Liu 8d5c38f0e5 refactor: unify providers and models tables (#338)
* refactor: unify providers and models tables

- Rename `llm_providers` → `providers`, `llm_provider_oauth_tokens` → `provider_oauth_tokens`
- Remove `tts_providers` and `tts_models` tables; speech models now live in the unified `models` table with `type = 'speech'`
- Replace top-level `api_key`/`base_url` columns with a JSONB `config` field on `providers`
- Rename `llm_provider_id` → `provider_id` across all references
- Add `edge-speech` client type and `conf/providers/edge.yaml` default provider
- Create new read-only speech endpoints (`/speech-providers`, `/speech-models`) backed by filtered views of the unified tables
- Remove old TTS CRUD handlers; simplify speech page to read-only + test
- Update registry loader to skip malformed YAML files instead of failing entirely
- Fix YAML quoting for model names containing colons in openrouter.yaml
- Regenerate sqlc, swagger, and TypeScript SDK

* fix: exclude speech providers from providers list endpoint

ListProviders now filters out client_type matching '%-speech' so Edge
and future speech providers no longer appear on the Providers page.
ListSpeechProviders uses the same pattern match instead of hard-coding
'edge-speech'.

* fix: use explicit client_type list instead of LIKE pattern

Replace '%-speech' pattern with explicit IN ('edge-speech') for both
ListProviders (exclusion) and ListSpeechProviders (inclusion). New
speech client types must be added to both queries.

* fix: use EXECUTE for dynamic SQL in migrations referencing old schema

PL/pgSQL pre-validates column/table references in static SQL statements
inside DO blocks before evaluating IF/RETURN guards. This caused
migrations 0010-0061 to fail on fresh databases where the canonical
schema uses `providers`/`provider_id` instead of `llm_providers`/
`llm_provider_id`.

Wrap all SQL that references potentially non-existent old schema objects
(llm_providers, llm_provider_id, tts_providers, tts_models, etc.) in
EXECUTE strings so they are only parsed at runtime when actually reached.

* fix: revert canonical schema to use llm_providers for migration compatibility

The CI migrations workflow (up → down → up) failed because 0061 down
renames `providers` back to `llm_providers`, but 0001 down only dropped
`providers` — leaving `llm_providers` as a remnant. On the second
migrate up, 0010 found the stale `llm_providers` and tried to reference
`models.llm_provider_id` which no longer existed.

Revert 0001 canonical schema to use original names (llm_providers,
tts_providers, tts_models) so incremental migrations work naturally and
0061 handles the final rename. Remove EXECUTE wrappers and unnecessary
guards from migrations that now always operate on llm_providers.

* fix: icons

* fix: sync canonical schema with 0061 migration to fix sqlc column mismatch

0001_init.up.sql still used old names (llm_providers, llm_provider_id)
and included dropped tts_providers/tts_models tables. sqlc could not
parse the PL/pgSQL EXECUTE in migration 0061, so generated code retained
stale columns (input_modalities, supports_reasoning) causing runtime
"column does not exist" errors when adding models.

- Update 0001_init.up.sql to current schema (providers, provider_id,
  no tts tables, add provider_oauth_tokens)
- Use ALTER TABLE IF EXISTS in 0010/0041/0042 for backward compat
- Regenerate sqlc

* fix: guard all legacy migrations against fresh schema for CI compat

On fresh databases, 0001_init.up.sql creates providers/provider_id
(not llm_providers/llm_provider_id). Migrations 0013, 0041, 0046, 0047
referenced the old names without guards, causing CI migration failures.

- 0013: check llm_provider_id column exists before adding old constraint
- 0041: check llm_providers table exists before backfill/constraint DDL
- 0046: wrap CREATE TABLE in DO block with llm_providers existence check
- 0047: use ALTER TABLE IF EXISTS + DO block guard
2026-04-08 01:03:44 +08:00

168 lines
5.1 KiB
Go

package flow
import (
"context"
"encoding/json"
"log/slog"
"strings"
"time"
sdk "github.com/memohai/twilight-ai/sdk"
"github.com/memohai/memoh/internal/conversation"
"github.com/memohai/memoh/internal/db/sqlc"
messageevent "github.com/memohai/memoh/internal/message/event"
"github.com/memohai/memoh/internal/models"
"github.com/memohai/memoh/internal/providers"
"github.com/memohai/memoh/internal/session"
)
const (
titlePromptMaxInputChars = 500
titleGenerateTimeout = 60 * time.Second
)
// SessionService is the interface the resolver uses for session title updates.
type SessionService interface {
Get(ctx context.Context, sessionID string) (session.Session, error)
UpdateTitle(ctx context.Context, sessionID, title string) (session.Session, error)
}
// SetSessionService configures the session service used for auto title generation.
func (r *Resolver) SetSessionService(s SessionService) {
r.sessionService = s
}
// SetEventPublisher configures the event publisher for broadcasting events
// such as session title updates.
func (r *Resolver) SetEventPublisher(p messageevent.Publisher) {
r.eventPublisher = p
}
// maybeGenerateSessionTitle checks whether the session needs an auto-generated
// title and, if so, calls the configured title model to produce one.
// It is fired asynchronously when a user message is received so the title
// appears as early as possible without blocking the chat flow.
func (r *Resolver) maybeGenerateSessionTitle(ctx context.Context, req conversation.ChatRequest, userQuery string) {
sessionID := strings.TrimSpace(req.SessionID)
if sessionID == "" || r.sessionService == nil {
return
}
userQuery = strings.TrimSpace(userQuery)
if userQuery == "" {
return
}
sess, err := r.sessionService.Get(ctx, sessionID)
if err != nil {
r.logger.Warn("title gen: failed to get session", slog.String("session_id", sessionID), slog.Any("error", err))
return
}
if strings.TrimSpace(sess.Title) != "" {
return
}
botSettings, err := r.loadBotSettings(ctx, req.BotID)
if err != nil {
r.logger.Warn("title gen: failed to load bot settings", slog.String("bot_id", req.BotID), slog.Any("error", err))
return
}
titleModelID := strings.TrimSpace(botSettings.TitleModelID)
if titleModelID == "" {
r.logger.Debug("title gen: no title model configured", slog.String("bot_id", req.BotID))
return
}
r.logger.Info("title gen: generating title", slog.String("session_id", sessionID), slog.String("title_model_id", titleModelID))
titleModel, provider, err := r.fetchChatModel(ctx, titleModelID)
if err != nil {
r.logger.Warn("title gen: failed to resolve title model", slog.String("model_id", titleModelID), slog.Any("error", err))
return
}
title := r.generateTitle(ctx, titleModel, provider, userQuery)
if title == "" {
return
}
if _, err := r.sessionService.UpdateTitle(ctx, sessionID, title); err != nil {
r.logger.Warn("title gen: failed to update session title", slog.String("session_id", sessionID), slog.Any("error", err))
} else {
r.logger.Info("title gen: session title updated", slog.String("session_id", sessionID), slog.String("title", title))
r.publishSessionTitleUpdated(req.BotID, sessionID, title)
}
}
func (r *Resolver) generateTitle(ctx context.Context, model models.GetResponse, provider sqlc.Provider, userQuery string) string {
userSnippet := truncate(strings.TrimSpace(userQuery), titlePromptMaxInputChars)
if userSnippet == "" {
return ""
}
prompt := "Generate a concise title (max 30 characters) for a conversation that starts with the following user message. " +
"Return ONLY the title text, nothing else.\n\n" +
"User: " + userSnippet
authResolver := providers.NewService(nil, r.queries, "")
creds, err := authResolver.ResolveModelCredentials(ctx, provider)
if err != nil {
r.logger.Warn("title gen: failed to resolve provider credentials", slog.Any("error", err))
return ""
}
modelCfg := models.SDKModelConfig{
ModelID: model.ModelID,
ClientType: provider.ClientType,
APIKey: creds.APIKey,
CodexAccountID: creds.CodexAccountID,
BaseURL: providers.ProviderConfigString(provider, "base_url"),
}
sdkModel := models.NewSDKChatModel(modelCfg)
genCtx, cancel := context.WithTimeout(ctx, titleGenerateTimeout)
defer cancel()
client := sdk.NewClient()
text, err := client.GenerateText(genCtx,
sdk.WithModel(sdkModel),
sdk.WithMessages([]sdk.Message{sdk.UserMessage(prompt)}),
)
if err != nil {
r.logger.Warn("title gen: LLM call failed", slog.Any("error", err))
return ""
}
title := strings.TrimSpace(text)
title = strings.Trim(title, "\"'`")
title = strings.TrimSpace(title)
return title
}
func (r *Resolver) publishSessionTitleUpdated(botID, sessionID, title string) {
if r.eventPublisher == nil {
return
}
data, err := json.Marshal(map[string]string{
"session_id": sessionID,
"title": title,
})
if err != nil {
return
}
r.eventPublisher.Publish(messageevent.Event{
Type: messageevent.EventTypeSessionTitleUpdated,
BotID: botID,
Data: data,
})
}
func truncate(s string, maxChars int) string {
runes := []rune(s)
if len(runes) <= maxChars {
return s
}
return string(runes[:maxChars])
}