Files
Memoh/internal/channel/adapters/discord/stream_test.go
T
BBQ d3bf6bc90a fix(channel,attachment): channel quality refactor & attachment pipeline fixes (#349)
* feat(channel): add DingTalk channel adapter

- Add DingTalk channel adapter (`internal/channel/adapters/dingtalk/`) using dingtalk-stream-sdk-go, supporting inbound message receiving and outbound text/markdown reply
- Register DingTalk adapter in cmd/agent and cmd/memoh
- Add go.mod dependency: github.com/memohai/dingtalk-stream-sdk-go
- Add Dingtalk and Wecom SVG icons and Vue components to @memohai/icon
- Refactor existing icon components to remove redundant inline wrappers
- Add `channelTypeDisplayName` util for consistent channel label resolution
- Add DingTalk/WeCom i18n entries (en/zh) for types and typesShort
- Extend channel-icon, bot-channels, channel-settings-panel to support dingtalk/wecom
- Use channelTypeDisplayName in profile page to replace ad-hoc i18n lookup

* fix(channel,attachment): channel quality refactor & attachment pipeline fixes

Channel module:
- Fix RemoveAdapter not cleaning connectionMeta (stale status leak)
- Fix preparedAttachmentTypeFromMime misclassifying image/gif
- Fix sleepWithContext time.After goroutine/timer leak
- Export IsDataURL/IsHTTPURL/IsDataPath, dedup across packages
- Cache OutboundPolicy in managerOutboundStream to avoid repeated lookups
- Split OutboundAttachmentStore: extract ContainerAttachmentIngester interface
- Add ManagerOption funcs (WithInboundQueueSize, WithInboundWorkers, WithRefreshInterval)
- Add thread-safety docs on OutboundStream / managerOutboundStream
- Add debug logs on successful send/edit paths
- Expand outbound_prepare_test.go with 21 new cases
- Convert no-receiver adapter helpers to package-level funcs; drop unused params

DingTalk adapter:
- Implement AttachmentResolver: download inbound media via /v1.0/robot/messageFiles/download
- Fix pure-image inbound messages failing due to missing resolver

Attachment pipeline:
- Fix images invisible to LLM in pipeline (DCP) path: inject InlineImages into
  last user message when cfg.Query is empty
- Fix public_url fallback: skip direct URL-to-LLM when ContentHash is set,
  always prefer inlined persisted asset
- Inject path: carry ImageParts through agent.InjectMessage; inline persisted
  attachments in resolver inject goroutine so mid-stream images reach the model
- Fix ResolveMime for images: prefer content-sniffed MIME over platform-declared
  MIME (fixes Feishu sending image/png header for actual JPEG content → API 400)
2026-04-09 14:36:11 +08:00

75 lines
2.0 KiB
Go

package discord
import (
"context"
"encoding/json"
"io"
"net/http"
"strings"
"testing"
"github.com/bwmarrin/discordgo"
"github.com/memohai/memoh/internal/channel"
)
type roundTripFunc func(*http.Request) (*http.Response, error)
func (f roundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) { return f(req) }
func TestDiscordOutboundStream_PushErrorEventRedactsSecrets(t *testing.T) {
channel.ResetIMErrorSecretsForTest()
t.Cleanup(channel.ResetIMErrorSecretsForTest)
const token = "discord-token-ABCDEFGHIJKLMNOPQRSTUVWXYZ"
channel.SetIMErrorSecrets("test", token)
prefixHalf := token[:len(token)/2]
var sentBody string
session, err := discordgo.New("Bot test")
if err != nil {
t.Fatalf("create session: %v", err)
}
session.Client = &http.Client{
Transport: roundTripFunc(func(req *http.Request) (*http.Response, error) {
body, _ := io.ReadAll(req.Body)
sentBody = string(body)
resp := &http.Response{
StatusCode: http.StatusOK,
Body: io.NopCloser(strings.NewReader(`{"id":"msg-1","channel_id":"ch-1"}`)),
Header: http.Header{"Content-Type": []string{"application/json"}},
}
return resp, nil
}),
}
stream := &discordOutboundStream{
adapter: &DiscordAdapter{},
target: "ch-1",
session: session,
}
err = stream.Push(context.Background(), channel.PreparedStreamEvent{
Type: channel.StreamEventError,
Error: "request failed: " + prefixHalf,
})
if err != nil {
t.Fatalf("push error event: %v", err)
}
var payload map[string]any
if err := json.Unmarshal([]byte(sentBody), &payload); err != nil {
t.Fatalf("decode sent body: %v (body=%q)", err, sentBody)
}
content, _ := payload["content"].(string)
if strings.Contains(content, prefixHalf) {
t.Fatalf("expected prefix half to be redacted, got %q", content)
}
if !strings.Contains(content, "Error: ") {
t.Fatalf("expected error prefix, got %q", content)
}
if !strings.Contains(content, strings.Repeat("*", len(prefixHalf))) {
t.Fatalf("expected redaction mask, got %q", content)
}
}