Files
Memoh/internal/command/settings.go
T
BBQ 7f9d6e4aba feat(acl): redesign ACL with conversation scope selector (#297)
Backend
- New subject kinds: all / channel_identity / channel_type
- Source scope fields on bot_acl_rules: source_channel,
  source_conversation_type, source_conversation_id, source_thread_id
- Fix source_scope_check constraint: resolve source_channel server-side
  (channel_type → subject_channel_type; channel_identity → DB lookup)
- Add GET /bots/:id/acl/channel-types/:type/conversations to list
  observed conversations by platform type
- ListObservedConversations: include private/DM chats, normalise
  conversation_type; COALESCE(name, handle) for display name
- enrichConversationAvatar: persist entry.Name → conversation_name
  (keeps Telegram group titles current on every message)
- Unify Priority type to int32 across Go types to match DB INTEGER;
  remove all int/int32 casts in service layer
- Fix duplicate nil guard in Evaluate; drop dead SourceScope.Channel field
- Migration 0048_acl_redesign

Frontend
- Drag-and-drop rule priority reordering (SortableJS/useSortable);
  fix reorder: compute new order from oldIndex/newIndex directly,
  not from the array (which useSortable syncs after onEnd)
- Conversation scope selector: searchable popover backed by observed
  conversations (by identity or platform type); collapsible manual-ID fallback
- Display: name as primary label, stable channel·type·id always shown
  as subtitle for verification
- bot-terminal: accessibility fix on close-tab button (keyboard events)
- i18n: drag-to-reorder, conversation source, manual IDs (en/zh)

Tests: update fakeChatACL to Evaluate interface; fix SourceScope literals.
SDK/spec regenerated.
2026-03-28 01:06:13 +08:00

196 lines
5.3 KiB
Go

package command
import (
"fmt"
"strconv"
"strings"
"github.com/memohai/memoh/internal/settings"
)
func (h *Handler) buildSettingsGroup() *CommandGroup {
g := newCommandGroup("settings", "View and update bot settings")
g.DefaultAction = "get"
g.Register(SubCommand{
Name: "get",
Usage: "get - View current settings",
Handler: func(cc CommandContext) (string, error) {
s, err := h.settingsService.GetBot(cc.Ctx, cc.BotID)
if err != nil {
return "", err
}
return formatKV([]kv{
{"Language", s.Language},
{"ACL Default Effect", s.AclDefaultEffect},
{"Max Context Load Time", fmt.Sprintf("%d min", s.MaxContextLoadTime)},
{"Max Context Tokens", strconv.Itoa(s.MaxContextTokens)},
{"Reasoning Enabled", boolStr(s.ReasoningEnabled)},
{"Reasoning Effort", s.ReasoningEffort},
{"Heartbeat Enabled", boolStr(s.HeartbeatEnabled)},
{"Heartbeat Interval", fmt.Sprintf("%d min", s.HeartbeatInterval)},
{"Chat Model", h.resolveModelName(cc, s.ChatModelID)},
{"Heartbeat Model", h.resolveModelName(cc, s.HeartbeatModelID)},
{"Search Provider", h.resolveSearchProviderName(cc, s.SearchProviderID)},
{"Memory Provider", h.resolveMemoryProviderName(cc, s.MemoryProviderID)},
{"Browser Context", h.resolveBrowserContextName(cc, s.BrowserContextID)},
}), nil
},
})
g.Register(SubCommand{
Name: "update",
Usage: "update [--language L] [--acl_default_effect allow|deny] ... - Update settings",
IsWrite: true,
Handler: func(cc CommandContext) (string, error) {
if len(cc.Args) == 0 {
return settingsUpdateUsage(), nil
}
req := settings.UpsertRequest{}
args := cc.Args
for i := 0; i < len(args); i++ {
if i+1 >= len(args) {
return fmt.Sprintf("Missing value for %s.\n\n%s", args[i], settingsUpdateUsage()), nil
}
switch args[i] {
case "--language":
i++
req.Language = args[i]
case "--acl_default_effect":
i++
req.AclDefaultEffect = args[i]
case "--reasoning_enabled":
i++
v := strings.ToLower(args[i]) == "true"
req.ReasoningEnabled = &v
case "--reasoning_effort":
i++
req.ReasoningEffort = &args[i]
case "--heartbeat_enabled":
i++
v := strings.ToLower(args[i]) == "true"
req.HeartbeatEnabled = &v
case "--heartbeat_interval":
i++
val, err := strconv.Atoi(args[i])
if err != nil {
return fmt.Sprintf("Invalid heartbeat_interval: %s", args[i]), nil
}
req.HeartbeatInterval = &val
case "--max_context_load_time":
i++
val, err := strconv.Atoi(args[i])
if err != nil {
return fmt.Sprintf("Invalid max_context_load_time: %s", args[i]), nil
}
req.MaxContextLoadTime = &val
case "--max_context_tokens":
i++
val, err := strconv.Atoi(args[i])
if err != nil {
return fmt.Sprintf("Invalid max_context_tokens: %s", args[i]), nil
}
req.MaxContextTokens = &val
case "--chat_model_id":
i++
req.ChatModelID = args[i]
case "--heartbeat_model_id":
i++
req.HeartbeatModelID = args[i]
default:
return fmt.Sprintf("Unknown option: %s\n\n%s", args[i], settingsUpdateUsage()), nil
}
}
_, err := h.settingsService.UpsertBot(cc.Ctx, cc.BotID, req)
if err != nil {
return "", err
}
return "Settings updated.", nil
},
})
return g
}
func settingsUpdateUsage() string {
return "Usage: /settings update [options]\n\n" +
"Options:\n" +
"- --language <value>\n" +
"- --acl_default_effect <allow|deny>\n" +
"- --reasoning_enabled <true|false>\n" +
"- --reasoning_effort <low|medium|high>\n" +
"- --heartbeat_enabled <true|false>\n" +
"- --heartbeat_interval <minutes>\n" +
"- --max_context_load_time <minutes>\n" +
"- --max_context_tokens <count>\n" +
"- --chat_model_id <id>\n" +
"- --heartbeat_model_id <id>"
}
// resolveModelName resolves a model UUID to "model_name (provider_name)".
func (h *Handler) resolveModelName(cc CommandContext, modelID string) string {
if modelID == "" {
return "(none)"
}
if h.modelsService == nil {
return modelID
}
m, err := h.modelsService.GetByID(cc.Ctx, modelID)
if err != nil {
return modelID
}
provName := ""
if h.providersService != nil {
p, err := h.providersService.Get(cc.Ctx, m.LlmProviderID)
if err == nil {
provName = p.Name
}
}
if provName != "" {
return fmt.Sprintf("%s (%s)", m.Name, provName)
}
return m.Name
}
// resolveSearchProviderName resolves a search provider UUID to its name.
func (h *Handler) resolveSearchProviderName(cc CommandContext, id string) string {
if id == "" {
return "(none)"
}
if h.searchProvService == nil {
return id
}
p, err := h.searchProvService.Get(cc.Ctx, id)
if err != nil {
return id
}
return p.Name
}
// resolveMemoryProviderName resolves a memory provider UUID to its name.
func (h *Handler) resolveMemoryProviderName(cc CommandContext, id string) string {
if id == "" {
return "(none)"
}
if h.memProvService == nil {
return id
}
p, err := h.memProvService.Get(cc.Ctx, id)
if err != nil {
return id
}
return p.Name
}
// resolveBrowserContextName resolves a browser context UUID to its name.
func (h *Handler) resolveBrowserContextName(cc CommandContext, id string) string {
if id == "" {
return "(none)"
}
if h.browserCtxService == nil {
return id
}
p, err := h.browserCtxService.GetByID(cc.Ctx, id)
if err != nil {
return id
}
return p.Name
}