Files
Memoh/internal/command/settings.go
T
Acbox Liu 8d5c38f0e5 refactor: unify providers and models tables (#338)
* refactor: unify providers and models tables

- Rename `llm_providers` → `providers`, `llm_provider_oauth_tokens` → `provider_oauth_tokens`
- Remove `tts_providers` and `tts_models` tables; speech models now live in the unified `models` table with `type = 'speech'`
- Replace top-level `api_key`/`base_url` columns with a JSONB `config` field on `providers`
- Rename `llm_provider_id` → `provider_id` across all references
- Add `edge-speech` client type and `conf/providers/edge.yaml` default provider
- Create new read-only speech endpoints (`/speech-providers`, `/speech-models`) backed by filtered views of the unified tables
- Remove old TTS CRUD handlers; simplify speech page to read-only + test
- Update registry loader to skip malformed YAML files instead of failing entirely
- Fix YAML quoting for model names containing colons in openrouter.yaml
- Regenerate sqlc, swagger, and TypeScript SDK

* fix: exclude speech providers from providers list endpoint

ListProviders now filters out client_type matching '%-speech' so Edge
and future speech providers no longer appear on the Providers page.
ListSpeechProviders uses the same pattern match instead of hard-coding
'edge-speech'.

* fix: use explicit client_type list instead of LIKE pattern

Replace '%-speech' pattern with explicit IN ('edge-speech') for both
ListProviders (exclusion) and ListSpeechProviders (inclusion). New
speech client types must be added to both queries.

* fix: use EXECUTE for dynamic SQL in migrations referencing old schema

PL/pgSQL pre-validates column/table references in static SQL statements
inside DO blocks before evaluating IF/RETURN guards. This caused
migrations 0010-0061 to fail on fresh databases where the canonical
schema uses `providers`/`provider_id` instead of `llm_providers`/
`llm_provider_id`.

Wrap all SQL that references potentially non-existent old schema objects
(llm_providers, llm_provider_id, tts_providers, tts_models, etc.) in
EXECUTE strings so they are only parsed at runtime when actually reached.

* fix: revert canonical schema to use llm_providers for migration compatibility

The CI migrations workflow (up → down → up) failed because 0061 down
renames `providers` back to `llm_providers`, but 0001 down only dropped
`providers` — leaving `llm_providers` as a remnant. On the second
migrate up, 0010 found the stale `llm_providers` and tried to reference
`models.llm_provider_id` which no longer existed.

Revert 0001 canonical schema to use original names (llm_providers,
tts_providers, tts_models) so incremental migrations work naturally and
0061 handles the final rename. Remove EXECUTE wrappers and unnecessary
guards from migrations that now always operate on llm_providers.

* fix: icons

* fix: sync canonical schema with 0061 migration to fix sqlc column mismatch

0001_init.up.sql still used old names (llm_providers, llm_provider_id)
and included dropped tts_providers/tts_models tables. sqlc could not
parse the PL/pgSQL EXECUTE in migration 0061, so generated code retained
stale columns (input_modalities, supports_reasoning) causing runtime
"column does not exist" errors when adding models.

- Update 0001_init.up.sql to current schema (providers, provider_id,
  no tts tables, add provider_oauth_tokens)
- Use ALTER TABLE IF EXISTS in 0010/0041/0042 for backward compat
- Regenerate sqlc

* fix: guard all legacy migrations against fresh schema for CI compat

On fresh databases, 0001_init.up.sql creates providers/provider_id
(not llm_providers/llm_provider_id). Migrations 0013, 0041, 0046, 0047
referenced the old names without guards, causing CI migration failures.

- 0013: check llm_provider_id column exists before adding old constraint
- 0041: check llm_providers table exists before backfill/constraint DDL
- 0046: wrap CREATE TABLE in DO block with llm_providers existence check
- 0047: use ALTER TABLE IF EXISTS + DO block guard
2026-04-08 01:03:44 +08:00

178 lines
4.7 KiB
Go

package command
import (
"fmt"
"strconv"
"strings"
"github.com/memohai/memoh/internal/settings"
)
func (h *Handler) buildSettingsGroup() *CommandGroup {
g := newCommandGroup("settings", "View and update bot settings")
g.DefaultAction = "get"
g.Register(SubCommand{
Name: "get",
Usage: "get - View current settings",
Handler: func(cc CommandContext) (string, error) {
s, err := h.settingsService.GetBot(cc.Ctx, cc.BotID)
if err != nil {
return "", err
}
return formatKV([]kv{
{"Language", s.Language},
{"ACL Default Effect", s.AclDefaultEffect},
{"Reasoning Enabled", boolStr(s.ReasoningEnabled)},
{"Reasoning Effort", s.ReasoningEffort},
{"Heartbeat Enabled", boolStr(s.HeartbeatEnabled)},
{"Heartbeat Interval", fmt.Sprintf("%d min", s.HeartbeatInterval)},
{"Chat Model", h.resolveModelName(cc, s.ChatModelID)},
{"Heartbeat Model", h.resolveModelName(cc, s.HeartbeatModelID)},
{"Search Provider", h.resolveSearchProviderName(cc, s.SearchProviderID)},
{"Memory Provider", h.resolveMemoryProviderName(cc, s.MemoryProviderID)},
{"Browser Context", h.resolveBrowserContextName(cc, s.BrowserContextID)},
}), nil
},
})
g.Register(SubCommand{
Name: "update",
Usage: "update [--language L] [--acl_default_effect allow|deny] ... - Update settings",
IsWrite: true,
Handler: func(cc CommandContext) (string, error) {
if len(cc.Args) == 0 {
return settingsUpdateUsage(), nil
}
req := settings.UpsertRequest{}
args := cc.Args
for i := 0; i < len(args); i++ {
if i+1 >= len(args) {
return fmt.Sprintf("Missing value for %s.\n\n%s", args[i], settingsUpdateUsage()), nil
}
switch args[i] {
case "--language":
i++
req.Language = args[i]
case "--acl_default_effect":
i++
req.AclDefaultEffect = args[i]
case "--reasoning_enabled":
i++
v := strings.ToLower(args[i]) == "true"
req.ReasoningEnabled = &v
case "--reasoning_effort":
i++
req.ReasoningEffort = &args[i]
case "--heartbeat_enabled":
i++
v := strings.ToLower(args[i]) == "true"
req.HeartbeatEnabled = &v
case "--heartbeat_interval":
i++
val, err := strconv.Atoi(args[i])
if err != nil {
return fmt.Sprintf("Invalid heartbeat_interval: %s", args[i]), nil
}
req.HeartbeatInterval = &val
case "--chat_model_id":
i++
req.ChatModelID = args[i]
case "--heartbeat_model_id":
i++
req.HeartbeatModelID = args[i]
default:
return fmt.Sprintf("Unknown option: %s\n\n%s", args[i], settingsUpdateUsage()), nil
}
}
_, err := h.settingsService.UpsertBot(cc.Ctx, cc.BotID, req)
if err != nil {
return "", err
}
return "Settings updated.", nil
},
})
return g
}
func settingsUpdateUsage() string {
return "Usage: /settings update [options]\n\n" +
"Options:\n" +
"- --language <value>\n" +
"- --acl_default_effect <allow|deny>\n" +
"- --reasoning_enabled <true|false>\n" +
"- --reasoning_effort <low|medium|high>\n" +
"- --heartbeat_enabled <true|false>\n" +
"- --heartbeat_interval <minutes>\n" +
"- --chat_model_id <id>\n" +
"- --heartbeat_model_id <id>"
}
// resolveModelName resolves a model UUID to "model_name (provider_name)".
func (h *Handler) resolveModelName(cc CommandContext, modelID string) string {
if modelID == "" {
return "(none)"
}
if h.modelsService == nil {
return modelID
}
m, err := h.modelsService.GetByID(cc.Ctx, modelID)
if err != nil {
return modelID
}
provName := ""
if h.providersService != nil {
p, err := h.providersService.Get(cc.Ctx, m.ProviderID)
if err == nil {
provName = p.Name
}
}
if provName != "" {
return fmt.Sprintf("%s (%s)", m.Name, provName)
}
return m.Name
}
// resolveSearchProviderName resolves a search provider UUID to its name.
func (h *Handler) resolveSearchProviderName(cc CommandContext, id string) string {
if id == "" {
return "(none)"
}
if h.searchProvService == nil {
return id
}
p, err := h.searchProvService.Get(cc.Ctx, id)
if err != nil {
return id
}
return p.Name
}
// resolveMemoryProviderName resolves a memory provider UUID to its name.
func (h *Handler) resolveMemoryProviderName(cc CommandContext, id string) string {
if id == "" {
return "(none)"
}
if h.memProvService == nil {
return id
}
p, err := h.memProvService.Get(cc.Ctx, id)
if err != nil {
return id
}
return p.Name
}
// resolveBrowserContextName resolves a browser context UUID to its name.
func (h *Handler) resolveBrowserContextName(cc CommandContext, id string) string {
if id == "" {
return "(none)"
}
if h.browserCtxService == nil {
return id
}
p, err := h.browserCtxService.GetByID(cc.Ctx, id)
if err != nil {
return id
}
return p.Name
}